Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 7988001: Revert 102216 - Fix activation problem when showing bubble view (Closed)

Created:
9 years, 3 months ago by tommi (sloooow) - chröme
Modified:
9 years, 3 months ago
Reviewers:
sail
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 102216 - Fix activation problem when showing bubble view If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close. The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close. Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus. This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active. BUG=95146 TEST= Review URL: http://codereview.chromium.org/7960001 TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tommi (sloooow) - chröme
9 years, 3 months ago (2011-09-22 11:07:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698