Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 7960001: Fix activation problem when showing bubble view (Closed)

Created:
9 years, 3 months ago by sail
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix activation problem when showing bubble view If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close. The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close. Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus. This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active. BUG=95146 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102216

Patch Set 1 #

Patch Set 2 : fix OmniboxApiTest.PopupStaysClosed failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sail
9 years, 3 months ago (2011-09-19 21:04:35 UTC) #1
sky
LGTM
9 years, 3 months ago (2011-09-19 23:53:52 UTC) #2
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 3 months ago (2011-09-20 02:54:46 UTC) #3
sail
9 years, 3 months ago (2011-09-21 22:40:34 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 00:50:37 UTC) #5
Change committed as 102216

Powered by Google App Engine
This is Rietveld 408576698