Issue 7983033: Fix broken Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7983033: Fix broken Windows build. (Closed)

Created:
9 years, 3 months ago by fschneider

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix broken Windows build. Committed: http://code.google.com/p/v8/source/detail?r=9369

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 3 months ago (2011-09-21 14:12:08 UTC) #2

LGTM

http://codereview.chromium.org/7983033/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/7983033/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:4319: v8::RegisterExtension(new
Extension(extension_name.start(),
This test is broken in a sense. 

It leaves dangling pointers inside V8 (extension names in Extension objects).

Expand Messages | Collapse Messages