Fix broken Windows build.

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc	(revision 9365)
+++ test/cctest/test-api.cc	(working copy)
@@ -4314,12 +4314,12 @@
   for (int source_len = kEmbeddedExtensionSourceValidLen - 1;
        source_len <= kEmbeddedExtensionSourceValidLen + 1; ++source_len) {
     v8::HandleScope handle_scope;
-    char extension_name[32];
-    snprintf(extension_name, sizeof(extension_name), "ext #%d", source_len);
-    v8::RegisterExtension(new Extension(extension_name,
+    i::ScopedVector<char> extension_name(32);
+    i::OS::SNPrintF(extension_name, "ext #%d", source_len);
+    v8::RegisterExtension(new Extension(extension_name.start(),

[Vyacheslav Egorov (Chromium), 2011/09/21 14:12:08]

This test is broken in a sense. 

It leaves dangling pointers inside V8 (extension names in Extension objects).

                                         kEmbeddedExtensionSource, 0, 0,
                                         source_len));
-    const char* extension_names[1] = { extension_name };
+    const char* extension_names[1] = { extension_name.start() };
     v8::ExtensionConfiguration extensions(1, extension_names);
     v8::Handle<Context> context = Context::New(&extensions);
     if (source_len == kEmbeddedExtensionSourceValidLen) {