Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/chromeos/login/mock_authenticator.cc

Issue 7982025: Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more obsolete comment fixed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/mock_authenticator.cc
diff --git a/chrome/browser/chromeos/login/mock_authenticator.cc b/chrome/browser/chromeos/login/mock_authenticator.cc
index 1d7df53e039cca8d0516cddd6b2aa19ff1b11914..5daf3df3a53403775ca6f657146a6eb265fa3f3d 100644
--- a/chrome/browser/chromeos/login/mock_authenticator.cc
+++ b/chrome/browser/chromeos/login/mock_authenticator.cc
@@ -6,7 +6,7 @@
namespace chromeos {
-bool MockAuthenticator::AuthenticateToLogin(Profile* profile,
+void MockAuthenticator::AuthenticateToLogin(Profile* profile,
const std::string& username,
const std::string& password,
const std::string& login_token,
@@ -15,26 +15,23 @@ bool MockAuthenticator::AuthenticateToLogin(Profile* profile,
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
NewRunnableMethod(this, &MockAuthenticator::OnLoginSuccess,
GaiaAuthConsumer::ClientLoginResult(), false));
- return true;
}
GoogleServiceAuthError error(
GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
NewRunnableMethod(this, &MockAuthenticator::OnLoginFailure,
LoginFailure::FromNetworkAuthFailure(error)));
- return false;
}
-bool MockAuthenticator::CompleteLogin(Profile* profile,
+void MockAuthenticator::CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) {
- return false;
}
-bool MockAuthenticator::AuthenticateToUnlock(const std::string& username,
+void MockAuthenticator::AuthenticateToUnlock(const std::string& username,
const std::string& password) {
- return AuthenticateToLogin(NULL /* not used */, username, password,
- std::string(), std::string());
+ AuthenticateToLogin(NULL /* not used */, username, password,
+ std::string(), std::string());
}
void MockAuthenticator::LoginOffTheRecord() {
« no previous file with comments | « chrome/browser/chromeos/login/mock_authenticator.h ('k') | chrome/browser/chromeos/login/parallel_authenticator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698