Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7982005: Move dependencies to a locked property. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Move dependencies to a (to be) locked property. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102777

Patch Set 1 #

Patch Set 2 : Not using locks yet since it's having issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M gclient.py View 1 6 chunks +11 lines, -9 lines 0 comments Download
M tests/gclient_test.py View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-20 17:14:42 UTC) #1
Dirk Pranke
LGTM. Sorry for the delay.
9 years, 3 months ago (2011-09-21 21:36:33 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/7982005/2001
9 years, 2 months ago (2011-09-26 19:35:42 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-09-26 19:41:20 UTC) #4 
Change committed as 102777

Powered by Google App Engine
This is Rietveld 408576698