Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: tests/gclient_test.py

Issue 7982005: Move dependencies to a locked property. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Not using locks yet since it's having issues Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_test.py
diff --git a/tests/gclient_test.py b/tests/gclient_test.py
index d477b96f4b9ee131bd5ac03364e9ef4f5308f267..435ba75ef13d057e760987072a85ec6a72813af7 100755
--- a/tests/gclient_test.py
+++ b/tests/gclient_test.py
@@ -134,7 +134,8 @@ class GclientTest(trial_dir.TestCase):
# The trick here is to manually process the list to make sure it's out of
# order.
for i in obj.dependencies:
- i.dependencies.sort(key=lambda x: x.name, reverse=reverse)
+ # pylint: disable=W0212
+ i._dependencies.sort(key=lambda x: x.name, reverse=reverse)
actual = self._get_processed()
# We don't care of the ordering of these items:
self.assertEquals(
@@ -209,22 +210,22 @@ class GclientTest(trial_dir.TestCase):
parser = gclient.Parser()
options, _ = parser.parse_args([])
obj = gclient.GClient('foo', options)
- obj.dependencies.append(
+ obj._dependencies.append(
gclient.Dependency(obj, 'foo', 'url', None, None, None, None, 'DEPS',
True))
- obj.dependencies.append(
+ obj._dependencies.append(
gclient.Dependency(obj, 'bar', 'url', None, None, None, None, 'DEPS',
True))
- obj.dependencies[0].dependencies.append(
+ obj.dependencies[0]._dependencies.append(
gclient.Dependency(
obj.dependencies[0], 'foo/dir1', 'url', None, None, None, None,
'DEPS', True))
- obj.dependencies[0].dependencies.append(
+ obj.dependencies[0]._dependencies.append(
gclient.Dependency(
obj.dependencies[0], 'foo/dir2',
gclient.GClientKeywords.FromImpl('bar'), None, None, None, None,
'DEPS', True))
- obj.dependencies[0].dependencies.append(
+ obj.dependencies[0]._dependencies.append(
gclient.Dependency(
obj.dependencies[0], 'foo/dir3',
gclient.GClientKeywords.FileImpl('url'), None, None, None, None,
« no previous file with comments | « gclient.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698