Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.h

Issue 7981045: Make infobars ignore button clicks when closing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_view.h
===================================================================
--- chrome/browser/ui/views/infobars/infobar_view.h (revision 103307)
+++ chrome/browser/ui/views/infobars/infobar_view.h (working copy)
@@ -51,16 +51,19 @@
static views::Label* CreateLabel(const string16& text);
// Creates a link with the appropriate font and color for an infobar.
+ // NOTE: Subclasses must ignore link clicks if we're unowned.
static views::Link* CreateLink(const string16& text,
views::LinkListener* listener,
const SkColor& background_color);
// Creates a menu button with an infobar-specific appearance.
+ // NOTE: Subclasses must ignore button presses if we're unowned.
static views::MenuButton* CreateMenuButton(
const string16& text,
views::ViewMenuDelegate* menu_delegate);
// Creates a text button with an infobar-specific appearance.
+ // NOTE: Subclasses must ignore button presses if we're unowned.
static views::TextButton* CreateTextButton(views::ButtonListener* listener,
const string16& text,
bool needs_elevation);
@@ -72,6 +75,8 @@
View* child) OVERRIDE;
// views::ButtonListener:
+ // NOTE: This must not be called if we're unowned. (Subclasses should ignore
+ // calls to ButtonPressed() in this case.)
virtual void ButtonPressed(views::Button* sender,
const views::Event& event) OVERRIDE;
@@ -88,8 +93,9 @@
// Convenience getter.
const InfoBarContainer::Delegate* container_delegate() const;
- // Show a menu at the specified position. By invoking this InfobarView ensures
- // the menu is destroyed at the appropriate time.
+ // Shows a menu at the specified position.
+ // NOTE: This must not be called if we're unowned. (Subclasses should ignore
+ // calls to RunMenu() in this case.)
void RunMenuAt(ui::MenuModel* menu_model,
views::MenuButton* button,
views::MenuItemView::AnchorPosition anchor);
« no previous file with comments | « chrome/browser/ui/views/infobars/extension_infobar.cc ('k') | chrome/browser/ui/views/infobars/infobar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698