Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 7981045: Make infobars ignore button clicks when closing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/extension_infobar.cc
===================================================================
--- chrome/browser/ui/views/infobars/extension_infobar.cc (revision 103307)
+++ chrome/browser/ui/views/infobars/extension_infobar.cc (working copy)
@@ -137,6 +137,8 @@
}
void ExtensionInfoBar::RunMenu(View* source, const gfx::Point& pt) {
+ if (!owned())
+ return; // We're closing; don't call anything, it might access the owner.
const Extension* extension = GetDelegate()->extension_host()->extension();
if (!extension->ShowConfigureContextMenus())
return;
@@ -148,7 +150,6 @@
new ExtensionContextMenuModel(extension, browser, NULL);
DCHECK_EQ(source, menu_);
RunMenuAt(options_menu_contents.get(), menu_, views::MenuItemView::TOPLEFT);
- // TODO(pkasting): this may be deleted after rewrite.
}
ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() {
« no previous file with comments | « chrome/browser/ui/views/infobars/confirm_infobar.cc ('k') | chrome/browser/ui/views/infobars/infobar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698