style plugin: Don't ignore style warnings on the linux clang trybots.

style plugin: Don't ignore style warnings on the linux clang trybots.

Two parts:
1.) Let the banned_directories_ require full directory matches, not
    just suffixes.
2.) Remove "clang" from banned_directories_. Now that mac builds just
    go into xcodebuild / out, it's no longer required.

Regressed in http://codereview.chromium.org/7824047

BUG=97452
TEST=Try jobs to linux_clang report style problems again.
tools/clang/plugin/tests/test.sh passes again.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102344

[Elliot Glaysher, 2011-09-22 17:22:15]

lgtm

On Wed, Sep 21, 2011 at 1:35 PM,  <thakis@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> style plugin: Don't ignore style warnings on the linux clang trybots.
>
> Two parts:
> 1.) Let the banned_directories_ require full directory matches, not
>    just suffixes.
> 2.) Remove "clang" from banned_directories_. Now that mac builds just
>    go into xcodebuild / out, it's no longer required.
>
> Regressed in http://codereview.chromium.org/7824047
>
> BUG=97452
> TEST=Try jobs to linux_clang report style problems again.lg
> tools/clang/plugin/tests/test.sh passes again.
>
>
> Please review this at http://codereview.chromium.org/7980045/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/clang/plugins/ChromeClassTester.cpp
>
>
> Index: tools/clang/plugins/ChromeClassTester.cpp
> diff --git a/tools/clang/plugins/ChromeClassTester.cpp
> b/tools/clang/plugins/ChromeClassTester.cpp
> index
>
927c65593ce676dc125f8d0670e40f3b0a392833..30a5010aa874216ce559a114d02e0bbee3761d42
> 100644
> --- a/tools/clang/plugins/ChromeClassTester.cpp
> +++ b/tools/clang/plugins/ChromeClassTester.cpp
> @@ -54,7 +54,6 @@ void ChromeClassTester::BuildBannedLists() {
>   banned_directories_.push_back("llvm/");
>   banned_directories_.push_back("ninja/");
>   banned_directories_.push_back("xcodebuild/");
> -  banned_directories_.push_back("clang/");
>
>   // You are standing in a mazy of twisty dependencies, all resolved by
>   // putting everything in the header.
> @@ -233,8 +232,14 @@ bool
> ChromeClassTester::InBannedDirectory(SourceLocation loc) {
>          it != banned_directories_.end(); ++it) {
>       // If we can find any of the banned path components in this path, then
>       // this file is rejected.
> -      if (b.find(*it) != std::string::npos)
> -        return true;
> +      size_t index = b.find(*it);
> +      if (index != std::string::npos) {
> +        bool matches_full_dir_name = index == 0 || b[index - 1] == '/';
> +        if ((*it)[0] == '/')
> +          matches_full_dir_name = true;
> +        if (matches_full_dir_name)
> +          return true;
> +      }
>     }
>   }
>
>
>
>

[commit-bot: I haz the power, 2011-09-22 17:39:02]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/thakis%40chromium.org/7980045/1