clang style plugin: Don't try to figure out src root.

clang style plugin: Don't try to figure out src root.

Instead, just ignore all files that have a banned directory anywhere
in the path. This basically replaces patch set 2 with patch set 1 from
http://codereview.chromium.org/6577011 . The motivation is that
a) build/common.gypi doesn't exist when building in goma
b) there are several build/common.gypi files in the tree.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99418

[Nico, 2011-09-02 18:07:30]

You were right all along!

[Elliot Glaysher, 2011-09-02 18:11:58]

On 2011/09/02 18:07:30, Nico wrote:
> You were right all along!

Wheeee! also lgtm.

[Nico, 2011-09-02 19:06:55]

hamaji: FYI

[hans, 2012-01-16 11:14:20]

http://codereview.chromium.org/7824047/diff/1/tools/clang/plugins/ChromeClass...
File tools/clang/plugins/ChromeClassTester.cpp (right):

http://codereview.chromium.org/7824047/diff/1/tools/clang/plugins/ChromeClass...
tools/clang/plugins/ChromeClassTester.cpp:46:
banned_directories_.push_back("usr/");
It's not uncommon to have Chromium checked out in
/usr/local/something/something. This, combined with matching against the full
path, seems to make the style checker ignore everything?

[Nico, 2012-01-16 16:20:14]

> It's not uncommon to have Chromium checked out in
> /usr/local/something/something. This, combined with matching against the full
> path, seems to make the style checker ignore everything?

Yes, that's right. There's a gnarly hack a bit further down that strips
"/usr/local/google", so at least googlers won't hit that (if they follow the
checkout instructions I read years ago, don't know if that's still the
recommended directory). If you can think of a better way to fix this, I'm all
ears :-)