PRESUBMIT.py - Issue 7980032: Fix false positive that occurred because _test.cc files were not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 7980032: Fix false positive that occurred because _test.cc files were not (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 888e69a1d46ce5b3680f0cb154e0f63c432b41fa..80f1a821298bf2ac7006a3ab29bda08cfa97a213 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -50,8 +50,7 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):

file_inclusion_pattern = r'.+%s' % source_extensions

file_exclusion_pattern = (

r'.+(_test_support|profile_sync_service_harness|'

- r'_(unit|browser|ui|perf)test)%s' %

- source_extensions)

+ r'_(unit|browser|ui|perf)?test)%s' % source_extensions)

Paweł Hajdan Jr. 2011/09/21 17:19:42 nit: While you're here, it's probably worth to add

Jói 2011/09/21 20:30:20 Done.

path_exclusion_pattern = r'.*[/\\](test|tool(s)?)[/\\].*'

base_function_pattern = r'ForTest(ing)?|for_test(ing)?'

« no previous file with comments | « no previous file | no next file » | no next file with comments »