Fix false positive that occurred because _test.cc files were not

PRESUBMIT.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 32 matching lines @@
   that ignores header files and may have some false positives. A
   better implementation would probably need a proper C++ parser.
   """
   # We only scan .cc files and the like, as the declaration of
   # for-testing functions in header files are hard to distinguish from
   # calls to such functions without a proper C++ parser.
   source_extensions = r'\.(cc|cpp|cxx|mm)$'
   file_inclusion_pattern = r'.+%s' % source_extensions
   file_exclusion_pattern = (
     r'.+(_test_support|profile_sync_service_harness|'
-    r'_(unit|browser|ui|perf)test)%s' %
-                            source_extensions)
+    r'_(unit|browser|ui|perf)?test)%s' % source_extensions)

[Paweł Hajdan Jr., 2011/09/21 17:19:42]

nit: While you're here, it's probably worth to add apitest to the regexp, i.e.
chrome/browser/extensions/extension_i18n_apitest.cc

Also, maybe sort the strings inside parentheses ().

[Jói, 2011/09/21 20:30:20]

Done.

   path_exclusion_pattern = r'.*[/\\](test|tool(s)?)[/\\].*'
 
   base_function_pattern = r'ForTest(ing)?|for_test(ing)?'
   inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)
   exclusion_pattern = input_api.re.compile(
     r'::[A-Za-z0-9_]+(%s)|(%s)[^;]+\{' % (
       base_function_pattern, base_function_pattern))
 
   def FilterFile(affected_file):
     black_list = ((file_exclusion_pattern, path_exclusion_pattern, ) +
@@ skipping 175 matching lines @@
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(_CheckSubversionConfig(input_api, output_api))
   return results
 
 
 def GetPreferredTrySlaves():
   return ['win', 'linux', 'mac']