Fix false positive that occurred because _test.cc files were not

Fix false positive that occurred because _test.cc files were not
matched by the whitelist regexp.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102159

[Jói, 2011-09-21 09:56:52]

Hi Pawel,

Thanks for reporting this false positive:

=====
** Presubmit Warnings **
You might be calling functions intended only for testing from
production code. Please verify that the following usages are OK,
and email joi@chromium.org if you are seeing false positives:
  chrome/browser/ui/webui/bidi_checker_web_ui_test.cc:93
    ResourceBundle::GetSharedInstance().OverrideLocalePakForTest(pak_path); \
  chrome/browser/ui/webui/bidi_checker_web_ui_test.cc:105
    ResourceBundle::GetSharedInstance().OverrideLocalePakForTest(FilePath());

Presubmit checks took 1.5s to calculate.
=====

The following patch should fix it.

Cheers,
Jói

[Paweł Hajdan Jr., 2011-09-21 17:19:42]

LGTM with a comment, thank you.

http://codereview.chromium.org/7980032/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/7980032/diff/1/PRESUBMIT.py#newcode53
PRESUBMIT.py:53: r'_(unit|browser|ui|perf)?test)%s' % source_extensions)
nit: While you're here, it's probably worth to add apitest to the regexp, i.e.
chrome/browser/extensions/extension_i18n_apitest.cc

Also, maybe sort the strings inside parentheses ().

[Jói, 2011-09-21 20:30:20]

Thanks, committing.

http://codereview.chromium.org/7980032/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/7980032/diff/1/PRESUBMIT.py#newcode53
PRESUBMIT.py:53: r'_(unit|browser|ui|perf)?test)%s' % source_extensions)
On 2011/09/21 17:19:42, Paweł Hajdan Jr. wrote:
> nit: While you're here, it's probably worth to add apitest to the regexp, i.e.
> chrome/browser/extensions/extension_i18n_apitest.cc
> 
> Also, maybe sort the strings inside parentheses ().

Done.