Issue 7980023: Fixes aura unit tests. There were a couple of problems:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7980023: Fixes aura unit tests. There were a couple of problems: (Closed)

Created:
9 years, 3 months ago by sky

Modified:
9 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes aura unit tests. There were a couple of problems: . Child windows weren't getting focused correctly. . ToplevelWindowContainer needed to be created in Desktop constructor. . MoveChildToFront needed to move layers too. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102057

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -24 lines)			Patch
M	ui/aura/desktop.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	ui/aura/event_filter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/event_filter.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/aura/toplevel_window_event_filter.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	ui/aura/window.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/aura/window.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	3 chunks	+29 lines, -1 line	0 comments	Download
M	ui/aura_shell/desktop_layout_manager.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura_shell/desktop_window.cc	View	2 chunks	+3 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages