Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/browser/extensions/extension_content_settings_api.h

Issue 7980011: Convert the PluginService interface to be an async wrapper around PluginList. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready for review Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_content_settings_api.h
diff --git a/chrome/browser/extensions/extension_content_settings_api.h b/chrome/browser/extensions/extension_content_settings_api.h
index 25aca13560efedbf05b6fb4ab530f0a45126d929..cc19f3046a95298aeb7656822c00e12b401b353c 100644
--- a/chrome/browser/extensions/extension_content_settings_api.h
+++ b/chrome/browser/extensions/extension_content_settings_api.h
@@ -7,14 +7,9 @@
#pragma once
#include "chrome/browser/extensions/extension_function.h"
+#include "webkit/plugins/npapi/plugin_group.h"
jam 2011/09/21 00:04:51 nit: can you just forward declare instead?
-namespace webkit {
-namespace npapi {
-
-class PluginList;
-
-}
-}
+class PluginService;
jam 2011/09/21 00:04:51 nit: doesn't look like this is needed
class ClearContentSettingsFunction : public SyncExtensionFunction {
public:
@@ -47,10 +42,7 @@ class GetResourceIdentifiersFunction : public AsyncExtensionFunction {
FRIEND_TEST_ALL_PREFIXES(ExtensionApiTest,
ContentSettingsGetResourceIdentifiers);
- void GetPluginsOnFileThread();
-
- // Used to override the global plugin list in tests.
- static void SetPluginListForTesting(webkit::npapi::PluginList* plugin_list);
+ void OnGotPluginGroups(std::vector<webkit::npapi::PluginGroup> groups);
jam 2011/09/21 00:04:51 nit: const ref
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTENT_SETTINGS_API_H__

Powered by Google App Engine
This is Rietveld 408576698