Convert the PluginService interface to be an async wrapper around PluginList.

chrome/browser/extensions/extension_content_settings_api.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTENT_SETTINGS_API_H__
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTENT_SETTINGS_API_H__
 #pragma once
 
 #include "chrome/browser/extensions/extension_function.h"
+#include "webkit/plugins/npapi/plugin_group.h"

[jam, 2011/09/21 00:04:51]

nit: can you just forward declare instead?

 
-namespace webkit {
-namespace npapi {
-
-class PluginList;
-
-}
-}
+class PluginService;

[jam, 2011/09/21 00:04:51]

nit: doesn't look like this is needed

 
 class ClearContentSettingsFunction : public SyncExtensionFunction {
  public:
   virtual bool RunImpl();
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.contentSettings.clear")
 };
 
 class GetContentSettingFunction : public SyncExtensionFunction {
  public:
@@ skipping 12 matching lines @@
 class GetResourceIdentifiersFunction : public AsyncExtensionFunction {
  public:
   virtual bool RunImpl();
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.contentSettings.getResourceIdentifiers")
 
  private:
   FRIEND_TEST_ALL_PREFIXES(ExtensionApiTest,
                            ContentSettingsGetResourceIdentifiers);
 
-  void GetPluginsOnFileThread();
-
-  // Used to override the global plugin list in tests.
-  static void SetPluginListForTesting(webkit::npapi::PluginList* plugin_list);
+  void OnGotPluginGroups(std::vector<webkit::npapi::PluginGroup> groups);

[jam, 2011/09/21 00:04:51]

nit: const ref

 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTENT_SETTINGS_API_H__