Fix memory leak on menu

MenuConfig::Create passes HFONT to Font ctor but this HFONT isn't deleted. PlatformFontWin keeps copied HFONT by InitWIthCopyOfHFONT rather than keeping passed HFONT.

BUG=96872
TEST=Manual on Win7


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102241

[yosin_UTC9, 2011-09-21 06:58:19]

Hi guys,
Could you review my change?

This change stops leaking one GDI object (font) whenever Chrome shows menu on
Windows.

Thanks in advance.
-yosi

[sky, 2011-09-21 14:01:45]

LGTM

[sky, 2011-09-21 14:48:27]

Can you also merge this one over to 15 too?

Thanks,

  -Scott

On Wed, Sep 21, 2011 at 7:01 AM, <sky@chromium.org> wrote:

> LGTM
>
>
>
http://codereview.chromium.**org/7978021/<http://codereview.chromium.org/7978...
>

[sky, 2011-09-21 22:31:57]

LGTM with the following change.

http://codereview.chromium.org/7978021/diff/1/views/controls/menu/menu_config...
File views/controls/menu/menu_config_win.cc (right):

http://codereview.chromium.org/7978021/diff/1/views/controls/menu/menu_config...
views/controls/menu/menu_config_win.cc:32: HFONT font =
CreateFontIndirect(&metrics.lfMenuFont);
Actually, could you change this to use base::win::ScopedHFONT.

[commit-bot: I haz the power, 2011-09-22 05:30:48]

Change committed as 102241