Fix memory leak on menu

views/controls/menu/menu_config_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/menu/menu_config.h"
 
 #include <windows.h>
 #include <uxtheme.h>
 #include <Vssym32.h>
 
@@ skipping 11 matching lines @@
 MenuConfig* MenuConfig::Create() {
   MenuConfig* config = new MenuConfig();
 
   config->text_color = NativeThemeWin::instance()->GetThemeColorWithDefault(
       NativeThemeWin::MENU, MENU_POPUPITEM, MPI_NORMAL, TMT_TEXTCOLOR,
       COLOR_MENUTEXT);
 
   NONCLIENTMETRICS metrics;
   base::win::GetNonClientMetrics(&metrics);
   l10n_util::AdjustUIFont(&(metrics.lfMenuFont));
   HFONT font = CreateFontIndirect(&metrics.lfMenuFont);

[sky, 2011/09/21 22:31:57]

Actually, could you change this to use base::win::ScopedHFONT.

   DLOG_ASSERT(font);
   config->font = gfx::Font(font);
+  DeleteObject(font);
 
   NativeTheme::ExtraParams extra;
   extra.menu_check.is_radio = false;
   extra.menu_check.is_selected = false;
   gfx::Size check_size = NativeTheme::instance()->GetPartSize(
       NativeTheme::kMenuCheck, NativeTheme::kNormal, extra);
   if (!check_size.IsEmpty()) {
     config->check_width = check_size.width();
     config->check_height = check_size.height();
   } else {
@@ skipping 48 matching lines @@
   config->item_no_icon_top_margin = config->item_top_margin;
 
   BOOL show_cues;
   config->show_mnemonics =
       (SystemParametersInfo(SPI_GETKEYBOARDCUES, 0, &show_cues, 0) &&
        show_cues == TRUE);
   return config;
 }
 
 }  // namespace views