ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc - Issue 7978019: Additional update on Pepper IME API and boilerplate thunk/proxy implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

Issue 7978019: Additional update on Pepper IME API and boilerplate thunk/proxy implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated in response to yzshen's comments. Especially msgs made async. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

index b6fcb790b718ef50108ddf78fff7dec52feceb20..0448da2c0ef4194ea4e909ae1b359f02e88aec87 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

@@ -69,9 +69,9 @@ PP_Bool HandleInputEvent(PP_Instance instance, PP_Resource input_event) {

case PP_INPUTEVENT_TYPE_UNDEFINED:

return PP_FALSE;

// TODO(nfullagar): Implement support for event types below.

- case PP_INPUTEVENT_TYPE_COMPOSITION_START:

- case PP_INPUTEVENT_TYPE_COMPOSITION_UPDATE:

- case PP_INPUTEVENT_TYPE_COMPOSITION_END:

+ case PP_INPUTEVENT_TYPE_IME_COMPOSITION_START:

+ case PP_INPUTEVENT_TYPE_IME_COMPOSITION_UPDATE:

+ case PP_INPUTEVENT_TYPE_IME_COMPOSITION_END:

case PP_INPUTEVENT_TYPE_IME_TEXT:

DebugPrintf(" No implementation for event type %d\n",

data.event_type);

« no previous file with comments | « ppapi/cpp/dev/ime_input_event_dev.cc ('k') | ppapi/ppapi_proxy.gypi » ('j') | ppapi/proxy/ppapi_messages.h » ('J')