ppapi/cpp/dev/ime_input_event_dev.cc - Issue 7978019: Additional update on Pepper IME API and boilerplate thunk/proxy implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/ime_input_event_dev.cc

Issue 7978019: Additional update on Pepper IME API and boilerplate thunk/proxy implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated in response to yzshen's comments. Especially msgs made async. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/cpp/dev/ime_input_event_dev.h ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc » ('j') | ppapi/proxy/ppapi_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/cpp/dev/ime_input_event_dev.cc

diff --git a/ppapi/cpp/dev/ime_input_event_dev.cc b/ppapi/cpp/dev/ime_input_event_dev.cc

index 21fe8795f838078991b3b9feadd238c81444cb96..bc1f387baa469339a3209fff4b3a0bc74b218d82 100644

--- a/ppapi/cpp/dev/ime_input_event_dev.cc

+++ b/ppapi/cpp/dev/ime_input_event_dev.cc

@@ -49,16 +49,11 @@ uint32_t IMEInputEvent_Dev::GetSegmentNumber() const {

pp_resource());

}

-std::pair<uint32_t, uint32_t>

-IMEInputEvent_Dev::GetSegmentAt(uint32_t index) const {

- std::pair<uint32_t, uint32_t> range(0, 0);

+uint32_t IMEInputEvent_Dev::GetSegmentOffset(uint32_t index) const {

if (!has_interface<PPB_IMEInputEvent_Dev>())

- return range;

- get_interface<PPB_IMEInputEvent_Dev>()->GetSegmentAt(pp_resource(),

- index,

- &range.first,

- &range.second);

- return range;

+ return 0;

+ return get_interface<PPB_IMEInputEvent_Dev>()->GetSegmentOffset(pp_resource(),

+ index);

}

int32_t IMEInputEvent_Dev::GetTargetSegment() const {