Enable sync for the settings from the Extension Settings API.

Enable sync for the settings from the Extension Settings API. 

Original patch by kalman@chromium.org.

BUG=94575
TEST=unit tests included
TBR=kalman@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102140

[akalin, 2011-09-21 06:52:23]

Original code review: http://codereview.chromium.org/7775008/

[akalin, 2011-09-21 06:58:50]

On 2011/09/21 06:52:23, akalin wrote:
> Original code review: http://codereview.chromium.org/7775008/

The linux trybot seems to have gotten to the compile step.  This may end up
working.  I'll check on this tomorrow morning and will check in if everything
looks copacetic.

[akalin, 2011-09-21 08:06:56]

On 2011/09/21 06:58:50, akalin wrote:
> On 2011/09/21 06:52:23, akalin wrote:
> > Original code review: http://codereview.chromium.org/7775008/
> 
> The linux trybot seems to have gotten to the compile step.  This may end up
> working.  I'll check on this tomorrow morning and will check in if everything
> looks copacetic.

Fixed Mac compile errors in extension_popup_controller_unittest.mm

[kalman_google, 2011-09-21 08:08:59]

Thanks on all counts.


On Wed, Sep 21, 2011 at 6:06 PM, <akalin@chromium.org> wrote:

> On 2011/09/21 06:58:50, akalin wrote:
>
>> On 2011/09/21 06:52:23, akalin wrote:
>> > Original code review:
http://codereview.chromium.**org/7775008/<http://codereview.chromium.org/7775...
>>
>
>  The linux trybot seems to have gotten to the compile step.  This may end
>> up
>> working.  I'll check on this tomorrow morning and will check in if
>> everything
>> looks copacetic.
>>
>
> Fixed Mac compile errors in
extension_popup_controller_**unittest.mm<http://extension_popup_controller_unittest.mm>
>
>
>
http://codereview.chromium.**org/7977018/<http://codereview.chromium.org/7977...
>

[akalin, 2011-09-21 11:57:06]

Fix race condition in ExtensionSettingsUIWrapper.

I forgot that it's bad to do anything in the constructor of a ref-counted class
that may change the ref count (since if it hits 0, it gets destroyed before the
constructor finishes, which is bad).

Doing another round of tryjobs.