chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc - Issue 7977018: Enable sync for the settings from the Extension Settings API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc

Issue 7977018: Enable sync for the settings from the Extension Settings API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix race condition in ExtensionSettingsUIWrapper::Core Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_settings_cached_leveldb_storage_unittest.cc ('k') | chrome/browser/extensions/extension_settings_leveldb_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc

diff --git a/chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc b/chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc

index 252b05dd9dafacc78f0ec939069310c90143deaf..8178e823b2ba2b91d8f163e6a07a3e402923c75c 100644

--- a/chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc

+++ b/chrome/browser/extensions/extension_settings_cached_noop_storage_unittest.cc

@@ -7,8 +7,8 @@

namespace {

ExtensionSettingsStorage* Param(

- ExtensionSettings* settings, const std::string& extension_id) {

- return settings->GetStorageForTesting(

+ const ExtensionSettings& settings, const std::string& extension_id) {

+ return settings.GetStorageForTesting(

ExtensionSettingsStorage::NOOP, true, extension_id);

}