Relanding precompiled header support for VS 2008, now enabled for

chrome/installer/mini_installer.gyp

Index: chrome/installer/mini_installer.gyp
diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp
index 6c41bd39eebf85835a652aa3028e85e05ab77d8b..a8a4e48bd4d48c85cc7e3dcb75cb2ae9715cb22c 100644
--- a/chrome/installer/mini_installer.gyp
+++ b/chrome/installer/mini_installer.gyp
@@ -175,6 +175,21 @@
         {
           'target_name': 'mini_installer',
           'type': 'executable',
+          'configurations': {
+            'Debug': {
+              # Disable precompiled headers for this project, to avoid
+              # linker errors when building with VS 2008.
+              #
+              # Note that putting this in the 'target_defaults'
+              # section earlier in the file does not successfully
+              # override the 'target_defaults' brought in by the
+              # build/win_precompile.gypi file, so the overriding
+              # needs to be done here, directly in the mini_installer
+              # target.
+              'msvs_precompiled_header': '',
+              'msvs_precompiled_source': '',
+            },
+          },
           'sources': [
             'mini_installer/chrome.release',
             'mini_installer/chrome_appid.cc',
@@ -208,6 +223,7 @@
               'action': [
                 'python',
                 '<(create_installer_archive_py_path)',
+

[jeanluc1, 2011/09/20 16:54:25]

Extra line on purpose?

[Jói, 2011/09/20 21:44:06]

No, fixed.

                 '--output_dir=<(PRODUCT_DIR)',
                 '--input_file=<(RULE_INPUT_PATH)',
                 # TODO(sgk):  may just use environment variables