Relanding precompiled header support for VS 2008, now enabled for

build/win_precompile.gypi

Index: build/win_precompile.gypi
diff --git a/build/win_precompile.gypi b/build/win_precompile.gypi
index 90bcdff615b3e9e25e6dc1a42e00f9dc260b525b..910afe8a4b9feb8ebb47461bc9c931750ab49cfc 100644
--- a/build/win_precompile.gypi
+++ b/build/win_precompile.gypi
@@ -3,18 +3,29 @@
 # found in the LICENSE file.
 
 # Include this file to make targets in your .gyp use the default
-# precompiled header on Windows.
+# precompiled header on Windows, in debug builds only as the official
+# builders blow up (out of memory) if precompiled headers are used for
+# release builds.
 
 {
   'conditions': [
-    # Restricted to VS 2010 until GYP also supports suppressing
-    # precompiled headers on .c files in VS 2008.
-    ['OS=="win" and (MSVS_VERSION=="2010" or MSVS_VERSION=="2010e")', {
-      'target_defaults': {
-        'msvs_precompiled_header': '<(DEPTH)/build/precompile.h',
-        'msvs_precompiled_source': '<(DEPTH)/build/precompile.cc',
-        'sources': ['<(DEPTH)/build/precompile.cc'],
-      },
-    }],
+    ['OS=="win"', {
+        'target_defaults': {
+          'configurations': {
+            'Debug': {
+              'msvs_precompiled_header': '<(DEPTH)/build/precompile.h',
+              'msvs_precompiled_source': '<(DEPTH)/build/precompile.cc',
+            },
+          },
+
+          # This can't go into the 'Debug' configuration, so even
+          # 'Release' gets the source file, but it contains nothing
+          # but comments so shouldn't have an effect there (the
+          # msvs_precompiled_header directive above, that only the
+          # Debug configuration gets, is what forces the include of
+          # the precompiled header file in all source files).

[jeanluc1, 2011/09/20 16:54:25]

That's one heck of a long sentence that's hard to parse. Perhaps something like:

Sources can't be specified inside the 'Debug' configuration.   Since
precompile.cc only contains comments, it won't have any effect for 'Release'
builds.  The usage of precompiled headers is triggered only by the
'msvs_precompiled_header', found in the 'Debug' configuration above.

[Jói, 2011/09/20 21:44:06]

Switched to just the following:

  # Sources can't be specified inside the 'Debug'
  # configuration. Since precompile.cc only contains
  # comments, it won't have any effect for 'Release' builds.

+          'sources': ['<(DEPTH)/build/precompile.cc'],
+        }
+      }],
   ],
 }