Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 7976025: Revert 102113 - Aura: Use extension-based file picker from CrOS for pure-views builds. (Closed)

Created:
9 years, 3 months ago by James Cook
Modified:
9 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, davemoore+watch_chromium.org, stevenjb, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org
Visibility:
Public.

Description

Revert 102113 - Aura: Use extension-based file picker from CrOS for pure-views builds. Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles and links, but does not yet run - the extension subsystem is not finding the resources for the file_manager component extension. The Aura build currently won't process keyboard or mouse events, so I don't have a good way to debug this. For now, added logging, and we'll get back to it when Aura is in better shape. BUG=chromium-os:20583 TEST=On plain ChromeOS, can still open a file with control-O file picker. Review URL: http://codereview.chromium.org/7941014 TBR=jamescook@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -60 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.h View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 6 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/extensions/file_manager_util.cc View 4 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/file_manager_dialog.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/shell_dialogs_aura.cc View 1 chunk +1 line, -5 lines 0 comments Download
MM chrome/common/chrome_switches.h View 2 chunks +1 line, -1 line 0 comments Download
MM chrome/common/chrome_switches.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Cook
9 years, 3 months ago (2011-09-21 16:44:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698