Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7941014: Use extension-based file picker from CrOS for Aura builds. (Closed)

Created:
9 years, 3 months ago by James Cook
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, davemoore+watch_chromium.org, stevenjb, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org
Visibility:
Public.

Description

Aura: Use extension-based file picker from CrOS for pure-views builds. Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles, links, and runs, but the dialog doesn't function yet - there's still some work to do to wire up the private JavaScript API calls. See crbug.com/97424 BUG=chromium-os:20583 TEST=On plain ChromeOS, can still open a file with control-O file picker. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102113 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102156

Patch Set 1 #

Patch Set 2 : Added warning if dialog won't open, builds/links with Linux+Aura, Linux+ChromeOS #

Patch Set 3 : init pref in correct place, fixes failing FileSystemExtensionApiTest.FileBrowserTest #

Patch Set 4 : file manager manifest included, dialog now opens #

Patch Set 5 : fix linux_touchui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -52 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/extensions/file_manager_util.cc View 1 2 3 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 3 chunks +24 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/file_manager_dialog.cc View 1 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/shell_dialogs_aura.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Zel, can you look at, or suggest another reviewer for, the changes in preferences, switches, ...
9 years, 3 months ago (2011-09-19 22:07:47 UTC) #1
Emmanuel Saint-loubert-Bié
> Emmanuel, please take a look at build/common.gypi and chrome/browser/ui/* LGTM. Thanks.
9 years, 3 months ago (2011-09-19 22:29:10 UTC) #2
James Cook
Robert, could you look at the changes in preferences, switches, and extension_file_browser_api.* ? I suspect ...
9 years, 3 months ago (2011-09-20 18:21:49 UTC) #3
rginda
9 years, 3 months ago (2011-09-20 23:25:52 UTC) #4
On 2011/09/20 18:21:49, James Cook (Chromium) wrote:
> Robert, could you look at the changes in
> preferences, switches, and extension_file_browser_api.* ?  I suspect Zel is
> swamped with perf, etc.

This LGTM, happy to see the code turned on somewhere other than OS_CHROMEOS :)

Powered by Google App Engine
This is Rietveld 408576698