Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7976017: Simplified print preview printer selection to be more consistent with Chrome (Closed)
Patch Set: Fixed flow in chrome Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc
index 4128be2d5b1e751a57fcabf28e8c44d0ffb333b4..754daa7f94ed50cc5b5f6e1077d003a3b3adf89f 100644
--- a/chrome/browser/ui/webui/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview_handler.cc
@@ -565,8 +565,6 @@ void PrintPreviewHandler::RegisterMessages() {
NewCallback(this, &PrintPreviewHandler::HandleShowSystemDialog));
web_ui_->RegisterMessageCallback("signIn",
NewCallback(this, &PrintPreviewHandler::HandleSignin));
- web_ui_->RegisterMessageCallback("printWithCloudPrint",
- NewCallback(this, &PrintPreviewHandler::HandlePrintWithCloudPrint));
web_ui_->RegisterMessageCallback("manageCloudPrinters",
NewCallback(this, &PrintPreviewHandler::HandleManageCloudPrint));
web_ui_->RegisterMessageCallback("manageLocalPrinters",
@@ -715,13 +713,16 @@ void PrintPreviewHandler::HandlePrint(const ListValue* args) {
settings->SetBoolean(printing::kSettingHeaderFooterEnabled, false);
- bool print_to_cloud = settings->HasKey(printing::kSettingCloudPrintId);
- if (print_to_cloud) {
+ bool is_cloud_printer = settings->HasKey(printing::kSettingCloudPrintId);
+ bool is_cloud_dialog = settings->HasKey(printing::kSettingCloudPrintDialog);
+ if (is_cloud_printer) {
std::string print_ticket;
args->GetString(1, &print_ticket);
SendCloudPrintJob(*settings, print_ticket);
} else if (print_to_pdf) {
HandlePrintToPdf(*settings);
+ } else if (is_cloud_dialog) {
+ HandlePrintWithCloudPrint();
} else {
ReportPrintSettingsStats(*settings);
ReportUserActionHistogram(PRINT_TO_PRINTER);
@@ -830,7 +831,7 @@ void PrintPreviewHandler::HandleSignin(const ListValue* /*args*/) {
cloud_print_signin_dialog::CreateCloudPrintSigninDialog(preview_tab());
}
-void PrintPreviewHandler::HandlePrintWithCloudPrint(const ListValue* /*args*/) {
+void PrintPreviewHandler::HandlePrintWithCloudPrint() {
// Record the number of times the user asks to print via cloud print
// instead of the print preview dialog.
ReportStats();

Powered by Google App Engine
This is Rietveld 408576698