Simplified print preview printer selection to be more consistent with Chrome

chrome/browser/ui/webui/print_preview_data_source.cc

Index: chrome/browser/ui/webui/print_preview_data_source.cc
diff --git a/chrome/browser/ui/webui/print_preview_data_source.cc b/chrome/browser/ui/webui/print_preview_data_source.cc
index 6383e86d0c1d20fc07031015dc32acde3581001c..af0fb4a7a3b2f3d65fc02f0f08cf51c4adc35a43 100644
--- a/chrome/browser/ui/webui/print_preview_data_source.cc
+++ b/chrome/browser/ui/webui/print_preview_data_source.cc
@@ -93,25 +93,25 @@ PrintPreviewDataSource::PrintPreviewDataSource()
   AddLocalizedString("printPreviewPageLabelPlural",
                      IDS_PRINT_PREVIEW_PAGE_LABEL_PLURAL);
   const string16 shortcut_text(UTF8ToUTF16(kAdvancedPrintShortcut));
+#if defined(OS_CHROMEOS)
+  AddLocalizedString("systemDialogOption",

[kmadhusu, 2011/09/21 21:57:41]

"systemDialogOption" is a just a escape hatch to use the native print system
dialog. Once the print preview is stable and has all the advanced options of
native dialog, we may remove this link forever. 

Is it the same for cloud print dialog option? It's better if you can create a
new link for this cloud print dialog link.  You may also want to document this
in the html file. 

[Albert Bodenhamer, 2011/09/22 23:23:39]

On Chrome OS, cloud print IS the system print dialog.  This is just an attempt
to make it more clear by changing the string but keeping the behavior consistent
with other platforms.

Eventually we want a single dialog that seemlessly does everything both dialogs
do today and we'll want to remove the link at that point.

I've pushed the string selection into the html.  Hopefully that will make things
more clear.

On 2011/09/21 21:57:41, kmadhusu wrote:

[kmadhusu, 2011/09/23 01:27:19]

Thanks for the clarification. On Chrome OS, if you have a link to print using
cloud print dialog, how are we going to handle the page range errors? (Having a
link does not solve this issue crbug.com/97175) 

[Albert Bodenhamer, 2011/09/23 16:34:25]

The link actually triggers the system print dialog behavior which generates a
new PDF based on default values.  The page range value is discarded so illegal
values aren't a problem.

The intent was to be more consistent with the system dialog option on other
platforms which starts clean.

On 2011/09/23 01:27:19, kmadhusu wrote:

+                     IDS_PRINT_PREVIEW_CLOUD_DIALOG_OPTION);
+  AddLocalizedString("printWithCloudPrint",
+                     IDS_PRINT_PREVIEW_MORE_PRINTERS);
+#else
   AddString("systemDialogOption", l10n_util::GetStringFUTF16(
       IDS_PRINT_PREVIEW_SYSTEM_DIALOG_OPTION,
       shortcut_text));
-
+  AddLocalizedString("printWithCloudPrint",
+                     IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT);

[kmadhusu, 2011/09/21 21:57:41]

IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT is a formatted string, Do you need to
pass the string values for the place holders?

[Albert Bodenhamer, 2011/09/22 23:23:39]

It has a non-translatable section for the service name, but it isn't
parameterized.  Am I missing something?

On 2011/09/21 21:57:41, kmadhusu wrote:

[kmadhusu, 2011/09/23 01:27:19]

I thought <ph> tags (place holder tags) allows us to add dynamic strings at run
time. I am not sure whether it is used to specify non-translatable section for
the service name.  I may be wrong. Can you provide some reference link?

Eg: Custom string example <ph name=TEST_NAME>$1<eg>Google</eg></ph>

'$1' refers to the argument passed along with this IDS... string.

[Albert Bodenhamer, 2011/09/23 16:34:25]

Strangely, I'm having a hard time finding public documentation on GRIT. I'll
send you an internal link separately. (And bug joi@ to get the docs live)

<ph> specifies a non-translatable element.  $1, $2, etc are parameters that can
be dynamically replaced at runtime.  Usually, parameters occur inside of a
non-translatable element, but not all non-translatable elements contain
parameters.

In this case, the <ph> marks the name of the Google Cloud Print service, but
doesn't contain any parameters.

On 2011/09/23 01:27:19, kmadhusu wrote:

+#endif
   AddLocalizedString("pageRangeInstruction",
                      IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION);
   AddLocalizedString("copiesInstruction", IDS_PRINT_PREVIEW_COPIES_INSTRUCTION);
   AddLocalizedString("signIn", IDS_PRINT_PREVIEW_SIGN_IN);
-  AddLocalizedString("cloudPrinters", IDS_PRINT_PREVIEW_CLOUD_PRINTERS);
-  AddLocalizedString("localPrinters", IDS_PRINT_PREVIEW_LOCAL_PRINTERS);
-  AddLocalizedString("manageCloudPrinters",
-                     IDS_PRINT_PREVIEW_MANAGE_CLOUD_PRINTERS);
-  AddLocalizedString("manageLocalPrinters",
-                     IDS_PRINT_PREVIEW_MANAGE_LOCAL_PRINTERS);
   AddLocalizedString("managePrinters", IDS_PRINT_PREVIEW_MANAGE_PRINTERS);
   AddLocalizedString("printWithCloudPrintWait",
                      IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT_WAIT);
-  AddLocalizedString("printWithCloudPrint",
-                     IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT);
   AddLocalizedString("incrementTitle", IDS_PRINT_PREVIEW_INCREMENT_TITLE);
   AddLocalizedString("decrementTitle", IDS_PRINT_PREVIEW_DECREMENT_TITLE);
   AddLocalizedString("printPagesLabel", IDS_PRINT_PREVIEW_PRINT_PAGES_LABEL);