Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 7972022: Minor debugging fix so we fetch promos every 3 min when we're testing. (Closed)

Created:
9 years, 3 months ago by achuithb
Modified:
9 years, 3 months ago
CC:
chromium-reviews, anantha
Visibility:
Public.

Description

Minor debugging fix so we fetch promos every 3 min when we're testing. BUG=93201 TEST=Launch chrome with --promo-service-url='http://achuithz600.mtv.corp.google.com/www/files/promoresource?hl='. Wait 5 min for the promoresource to get downloaded, then relaunch chrome (with the same switch) and go to the ntp. You should see the chromebook promo. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102455

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/web_resource/promo_resource_service.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
achuithb
Need a quick review on this so testing can proceed.
9 years, 3 months ago (2011-09-22 23:39:19 UTC) #1
Dan Beam
quick lgtm
9 years, 3 months ago (2011-09-22 23:52:49 UTC) #2
achuithb
Add anantha to cc. will need this CL for testing promo service, unless you want ...
9 years, 3 months ago (2011-09-22 23:54:24 UTC) #3
Dan Beam
I might mention that you can simply change the constant yourself while debugging and revert, ...
9 years, 3 months ago (2011-09-22 23:58:32 UTC) #4
achuithb
dbeam: That's what I've been doing in my own testing, but I need a way ...
9 years, 3 months ago (2011-09-23 00:03:09 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/7972022/2003
9 years, 3 months ago (2011-09-23 05:15:55 UTC) #6
Miranda Callahan
On 2011/09/23 05:15:55, I haz the power (commit-bot) wrote: > CQ is trying tha patch. ...
9 years, 3 months ago (2011-09-23 06:25:35 UTC) #7
commit-bot: I haz the power
9 years, 3 months ago (2011-09-23 07:43:38 UTC) #8
Change committed as 102455

Powered by Google App Engine
This is Rietveld 408576698