ConfigurationPolicyPrefStore refactoring to surface error messages.

chrome/browser/policy/config_dir_policy_provider_unittest.cc

Index: chrome/browser/policy/config_dir_policy_provider_unittest.cc
diff --git a/chrome/browser/policy/config_dir_policy_provider_unittest.cc b/chrome/browser/policy/config_dir_policy_provider_unittest.cc
index 0b3b32c466f075d37bde5b51ff2eec7f02069a7d..878d2a297fcf15129c5a91780e4df69c25a8048c 100644
--- a/chrome/browser/policy/config_dir_policy_provider_unittest.cc
+++ b/chrome/browser/policy/config_dir_policy_provider_unittest.cc
@@ -193,18 +193,6 @@ TEST_P(ConfigDirPolicyProviderValueTest, Default) {
   EXPECT_TRUE(policy_map.empty());
 }
 
-TEST_P(ConfigDirPolicyProviderValueTest, NullValue) {

[Mattias Nissler (ping if slow), 2011/09/30 09:01:33]

I don't understand why you removed this.

[simo, 2011/09/30 13:00:41]

Because as far as I can see it, this test was meant to make sure that if you
pass in a NullValue to a provider, it will not be added to the PolicyMap. This
isn't the case anymore since I add any value to the map.

[Mattias Nissler (ping if slow), 2011/09/30 13:33:35]

Ah, I see. This is correct, the test is obsolete.

-  DictionaryValue dict;
-  dict.Set(GetParam().policy_key(), Value::CreateNullValue());
-  WriteConfigFile(dict, "empty");
-  ConfigDirPolicyProvider provider(
-      ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
-      test_dir());
-  PolicyMap policy_map;
-  EXPECT_TRUE(provider.Provide(&policy_map));
-  EXPECT_TRUE(policy_map.empty());
-}
-
 TEST_P(ConfigDirPolicyProviderValueTest, TestValue) {
   DictionaryValue dict;
   dict.Set(GetParam().policy_key(), GetParam().test_value()->DeepCopy());