ConfigurationPolicyPrefStore refactoring to surface error messages.

chrome/browser/policy/config_dir_policy_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_number_conversions.h"
@@ skipping 175 matching lines @@
 
 TEST_P(ConfigDirPolicyProviderValueTest, Default) {
   ConfigDirPolicyProvider provider(
       ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
       test_dir());
   PolicyMap policy_map;
   EXPECT_TRUE(provider.Provide(&policy_map));
   EXPECT_TRUE(policy_map.empty());
 }
 
-TEST_P(ConfigDirPolicyProviderValueTest, NullValue) {

[Mattias Nissler (ping if slow), 2011/09/30 09:01:33]

I don't understand why you removed this.

[simo, 2011/09/30 13:00:41]

Because as far as I can see it, this test was meant to make sure that if you
pass in a NullValue to a provider, it will not be added to the PolicyMap. This
isn't the case anymore since I add any value to the map.

[Mattias Nissler (ping if slow), 2011/09/30 13:33:35]

Ah, I see. This is correct, the test is obsolete.

-  DictionaryValue dict;
-  dict.Set(GetParam().policy_key(), Value::CreateNullValue());
-  WriteConfigFile(dict, "empty");
-  ConfigDirPolicyProvider provider(
-      ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
-      test_dir());
-  PolicyMap policy_map;
-  EXPECT_TRUE(provider.Provide(&policy_map));
-  EXPECT_TRUE(policy_map.empty());
-}
-
 TEST_P(ConfigDirPolicyProviderValueTest, TestValue) {
   DictionaryValue dict;
   dict.Set(GetParam().policy_key(), GetParam().test_value()->DeepCopy());
   WriteConfigFile(dict, "policy");
   ConfigDirPolicyProvider provider(
       ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
       test_dir());
   PolicyMap policy_map;
   EXPECT_TRUE(provider.Provide(&policy_map));
   EXPECT_EQ(1U, policy_map.size());
@@ skipping 165 matching lines @@
     ConfigDirPolicyProviderValueTest,
     testing::Values(
         ValueTestParams::ForListPolicy(
             kPolicyURLBlacklist,
             key::kURLBlacklist),
         ValueTestParams::ForListPolicy(
             kPolicyURLWhitelist,
             key::kURLWhitelist)));
 
 }  // namespace policy