chrome/browser/policy/configuration_policy_provider.cc - Issue 7972013: ConfigurationPolicyPrefStore refactoring to surface error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_provider.cc

Issue 7972013: ConfigurationPolicyPrefStore refactoring to surface error messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/configuration_policy_pref_store.cc ('K') | « chrome/browser/policy/configuration_policy_pref_store.cc ('k') | chrome/browser/policy/policy_error_map.h » ('j') | chrome/browser/policy/policy_error_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_provider.cc

diff --git a/chrome/browser/policy/configuration_policy_provider.cc b/chrome/browser/policy/configuration_policy_provider.cc

index 1c9e80de226595ae81a2dbd96bba213024a77e1d..2b9a2d01411fe4e99724232d31fa076ccfdf8141 100644

--- a/chrome/browser/policy/configuration_policy_provider.cc

+++ b/chrome/browser/policy/configuration_policy_provider.cc

@@ -29,7 +29,7 @@ void ConfigurationPolicyProvider::ApplyPolicyValueTree(

for (const PolicyDefinitionList::Entry* i = policy_list->begin;

i != policy_list->end; ++i) {

Value* value;

- if (policies->Get(i->name, &value) && value->IsType(i->value_type))

+ if (policies->Get(i->name, &value) && !value->IsType(Value::TYPE_NULL))

Mattias Nissler (ping if slow) 2011/09/20 13:12:25 just remove the type check entirely.

simo 2011/09/22 11:43:26 Done.

result->Set(i->policy_type, value->DeepCopy());

}