ConfigurationPolicyPrefStore refactoring to surface error messages.

chrome/browser/policy/configuration_policy_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_provider.h"
 
 #include "base/values.h"
 #include "chrome/browser/policy/policy_map.h"
 
 namespace policy {
@@ skipping 11 matching lines @@
   return true;
 }
 
 void ConfigurationPolicyProvider::ApplyPolicyValueTree(
     const DictionaryValue* policies,
     PolicyMap* result) {
   const PolicyDefinitionList* policy_list(policy_definition_list());
   for (const PolicyDefinitionList::Entry* i = policy_list->begin;
        i != policy_list->end; ++i) {
     Value* value;
-    if (policies->Get(i->name, &value) && value->IsType(i->value_type))
+    if (policies->Get(i->name, &value) && !value->IsType(Value::TYPE_NULL))

[Mattias Nissler (ping if slow), 2011/09/20 13:12:25]

just remove the type check entirely.

[simo, 2011/09/22 11:43:26]

Done.

       result->Set(i->policy_type, value->DeepCopy());
   }
 
   // TODO(mnissler): Handle preference overrides once |ConfigurationPolicyStore|
   // supports it.
 }
 
 // Class ConfigurationPolicyObserverRegistrar.
 
 ConfigurationPolicyObserverRegistrar::ConfigurationPolicyObserverRegistrar()
@@ skipping 17 matching lines @@
   observer_->OnUpdatePolicy();
 }
 
 void ConfigurationPolicyObserverRegistrar::OnProviderGoingAway() {
   observer_->OnProviderGoingAway();
   provider_->RemoveObserver(this);
   provider_ = NULL;
 }
 
 }  // namespace policy