|
Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs (Patch set 1 Reverts revert of http://codereview.chromium.org/7670041/)
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG= 96935
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102071
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+303 lines, -237 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
build/common.gypi
|
View
|
1
2
|
6 chunks |
+0 lines, -16 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/bookmarks/bookmark_context_menu_controller.cc
|
View
|
|
2 chunks |
+6 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/bookmarks/bookmark_editor.h
|
View
|
|
2 chunks |
+36 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/bookmarks/bookmark_editor.cc
|
View
|
|
1 chunk |
+40 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/browser_resources.grd
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/certificate_viewer.h
|
View
|
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/sync/test/integration/bookmarks_helper.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/browser.cc
|
View
|
1
2
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/browser_dialogs.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
|
View
|
|
2 chunks |
+4 lines, -15 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/cocoa/browser_window_controller.mm
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/cocoa/hung_renderer_controller.mm
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
|
View
|
|
1 chunk |
+2 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc
|
View
|
|
9 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
D |
chrome/browser/ui/gtk/certificate_viewer.h
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/gtk/certificate_viewer.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
|
View
|
|
3 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc
|
View
|
|
2 chunks |
+4 lines, -15 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
|
View
|
|
11 chunks |
+22 lines, -13 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/views/hung_renderer_view.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/bookmarks_ui.cc
|
View
|
|
3 chunks |
+38 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/certificate_viewer.h
|
View
|
1
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/certificate_viewer.cc
|
View
|
1
|
4 chunks |
+17 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/chrome_web_ui.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/chrome_web_ui.cc
|
View
|
|
2 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/chrome_web_ui_factory.cc
|
View
|
|
3 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/html_dialog_ui.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/html_dialog_ui.cc
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/hung_renderer_dialog.h
|
View
|
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/ui/webui/hung_renderer_dialog.cc
|
View
|
|
8 chunks |
+25 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/chrome_browser.gypi
|
View
|
1
2
|
5 chunks |
+3 lines, -36 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/common/chrome_switches.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/common/chrome_switches.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|