Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8162)

Unified Diff: chrome/chrome_browser.gypi

Issue 7957002: Reland add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/hung_renderer_dialog.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index aa33877f98e6de2bb9d267d74ef1478cfb6ad351..0d4d79c2de2bdf3edc23cabf2abc65524aa0e4e5 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2820,7 +2820,6 @@
'browser/ui/gtk/certificate_dialogs.cc',
'browser/ui/gtk/certificate_dialogs.h',
'browser/ui/gtk/certificate_viewer.cc',
- 'browser/ui/gtk/certificate_viewer.h',
'browser/ui/gtk/chrome_gtk_frame.cc',
'browser/ui/gtk/chrome_gtk_frame.h',
'browser/ui/gtk/collected_cookies_gtk.cc',
@@ -4106,14 +4105,9 @@
'../ui/aura/aura.gyp:aura',
],
}],
- ['webui_dialogs == 1', {
- 'defines': [
- 'WEBUI_DIALOGS',
- ],
- }],
- # Exclude WebUI certificate viewer if not POSIX, mac (these OS's have
- # native certificate viewers) or WebUI dialogs are disabled.
- ['webui_dialogs == 0 or os_posix == 0 or OS == "mac"', {
+ # Exclude WebUI certificate viewer if not POSIX or mac (these OS's have
+ # native certificate viewers).
+ ['os_posix == 0 or OS == "mac"', {
'sources/': [
['exclude', '^browser/ui/webui/certificate_viewer.cc'],
['exclude', '^browser/ui/webui/certificate_viewer.h'],
@@ -4121,23 +4115,6 @@
['exclude', '^browser/ui/webui/certificate_viewer_ui.h'],
],
}],
- # Exclude other WebUI dialogs if WebUI dialogs are disabled.
- ['webui_dialogs == 0', {
- 'sources/': [
- ['exclude', '^browser/ui/webui/hung_renderer_dialog.cc'],
- ['exclude', '^browser/ui/webui/hung_renderer_dialog.h'],
- ['exclude', '^browser/ui/webui/hung_renderer_dialog_ui.cc'],
- ['exclude', '^browser/ui/webui/hung_renderer_dialog_ui.h'],
- ],
- }],
- ['webui_dialogs == 1', {
- 'sources/': [
- ['exclude', '^browser/ui/gtk/certificate_viewer.cc'],
- ['exclude', '^browser/ui/gtk/certificate_viewer.h'],
- ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc'],
- ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.h'],
- ],
- }],
['toolkit_uses_gtk == 1', {
'dependencies': [
'../build/linux/system.gyp:dbus',
@@ -4462,7 +4439,6 @@
['include', '^browser/ui/gtk/certificate_dialogs.cc'],
['include', '^browser/ui/gtk/certificate_dialogs.h'],
['include', '^browser/ui/gtk/certificate_viewer.cc'],
- ['include', '^browser/ui/gtk/certificate_viewer.h'],
['include', '^browser/ui/gtk/chrome_gtk_frame.cc'],
['include', '^browser/ui/gtk/chrome_gtk_frame.h'],
['include', '^browser/ui/gtk/collected_cookies_gtk.cc'],
@@ -4775,15 +4751,6 @@
['exclude', '^browser/ui/panels/panel_mouse_watcher_gtk.cc'],
],
}],
- # Exclude the GTK versions of dialogs if webui_dialogs are enabled.
- ['webui_dialogs==1', {
- 'sources/': [
- ['exclude', '^browser/ui/gtk/certificate_viewer.cc'],
- ['exclude', '^browser/ui/gtk/certificate_viewer.h'],
- ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc'],
- ['exclude', '^browser/ui/gtk/hung_renderer_dialog_gtk.cc.h'],
- ],
- }],
# Exclude these toolkit_views specific files again.
# (Required because of the '^browser/extensions/' include above)
['toolkit_views==0', {
« no previous file with comments | « chrome/browser/ui/webui/hung_renderer_dialog.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698