Get rid of content::DidEndMainMessageLoop since it was declared in content but defined in chrome,...

chrome/browser/chrome_browser_main_mac.mm

Index: chrome/browser/chrome_browser_main_mac.mm
===================================================================
--- chrome/browser/chrome_browser_main_mac.mm	(revision 101766)
+++ chrome/browser/chrome_browser_main_mac.mm	(working copy)
@@ -24,15 +24,6 @@
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 
-namespace content {
-
-void DidEndMainMessageLoop() {
-  AppController* appController = [NSApp delegate];
-  [appController didEndMainMessageLoop];
-}
-
-}
-
 void RecordBreakpadStatusUMA(MetricsService* metrics) {
   metrics->RecordBreakpadRegistration(IsCrashReporterEnabled());
   metrics->RecordBreakpadHasDebugger(base::debug::BeingDebugged());
@@ -136,3 +127,8 @@
   [[NSUserDefaults standardUserDefaults]
       setObject:@"NO" forKey:@"NSTreatUnknownArgumentsAsOpen"];
 }
+
+void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {

[willchan no longer on Chromium, 2011/09/19 21:52:49]

I think we should just move this into PostMainMessageLoopRun(). Then we don't
need chrome_browser_main.cc to know about this function.

[jam, 2011/09/19 22:13:31]

That's what I had tried last week, but that didn't work since that function
needs the message loop to be running and some other objects that are destructed
by the time PostMainMessageLoopRun is run.

[willchan no longer on Chromium, 2011/09/19 22:25:43]

Sounds like shutdown ordering is busted here. I still don't think this should
exist and we should create a better pattern with more defined shutdown ordering,
but there's no need to block this changelist on it.

+  AppController* appController = [NSApp delegate];
+  [appController didEndMainMessageLoop];
+}