Get rid of content::DidEndMainMessageLoop since it was declared in content but defined in chrome,...

chrome/browser/chrome_browser_main_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/file_path.h"
 #include "base/mac/mac_util.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/path_service.h"
 #include "chrome/app/breakpad_mac.h"
 #import "chrome/browser/app_controller_mac.h"
 #import "chrome/browser/chrome_browser_application_mac.h"
 #import "chrome/browser/mac/keystone_glue.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/common/main_function_params.h"
 #include "content/common/result_codes.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 
-namespace content {
-
-void DidEndMainMessageLoop() {
-  AppController* appController = [NSApp delegate];
-  [appController didEndMainMessageLoop];
-}
-
-}
-
 void RecordBreakpadStatusUMA(MetricsService* metrics) {
   metrics->RecordBreakpadRegistration(IsCrashReporterEnabled());
   metrics->RecordBreakpadHasDebugger(base::debug::BeingDebugged());
 }
 
 void RecordBrowserStartupTime() {
   // Not implemented on Mac for now.
 }
 
 void WarnAboutMinimumSystemRequirements() {
@@ skipping 83 matching lines @@
 
   // This is a no-op if the KeystoneRegistration framework is not present.
   // The framework is only distributed with branded Google Chrome builds.
   [[KeystoneGlue defaultKeystoneGlue] registerWithKeystone];
 
   // Prevent Cocoa from turning command-line arguments into
   // |-application:openFiles:|, since we already handle them directly.
   [[NSUserDefaults standardUserDefaults]
       setObject:@"NO" forKey:@"NSTreatUnknownArgumentsAsOpen"];
 }
+
+void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {

[willchan no longer on Chromium, 2011/09/19 21:52:49]

I think we should just move this into PostMainMessageLoopRun(). Then we don't
need chrome_browser_main.cc to know about this function.

[jam, 2011/09/19 22:13:31]

That's what I had tried last week, but that didn't work since that function
needs the message loop to be running and some other objects that are destructed
by the time PostMainMessageLoopRun is run.

[willchan no longer on Chromium, 2011/09/19 22:25:43]

Sounds like shutdown ordering is busted here. I still don't think this should
exist and we should create a better pattern with more defined shutdown ordering,
but there's no need to block this changelist on it.

+  AppController* appController = [NSApp delegate];
+  [appController didEndMainMessageLoop];
+}