Issue 7945017: Temporary revert of r101474, will re-land tomorrow with a change to disable use of precompiled he...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7945017: Temporary revert of r101474, will re-land tomorrow with a change to disable use of precompiled he... (Closed)

Created:
9 years, 3 months ago by Jói

Modified:
9 years, 3 months ago

Reviewers:
Jói

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Temporary revert of r101474, will re-land tomorrow with a change to disable use of precompiled headers in Release builds as our Canary builds are failing with out of memory messages. Original change description: Switch on use of precompiled headers for VS 2008. The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly. On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project. BUG=none TEST=it builds (esp. on Windows), existing tests pass Review URL: http://codereview.chromium.org/7910002 TBR=laforge@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101836

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -11 lines)			Patch
M	base/time_win.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	build/win_precompile.gypi	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages