Switch on use of precompiled headers for VS 2008.

Switch on use of precompiled headers for VS 2008.

The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly.

On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project.

BUG=none
TEST=it builds (esp. on Windows), existing tests pass

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101474

[Jói, 2011-09-15 13:36:09]

Jean-Luc: Main reviewer.
Brett: For base/OWNERS.

[brettw, 2011-09-15 18:03:15]

http://codereview.chromium.org/7910002/diff/1005/base/time_win.cc
File base/time_win.cc (right):

http://codereview.chromium.org/7910002/diff/1005/base/time_win.cc#newcode371
base/time_win.cc:371: return abs(static_cast<long>((UnreliableNow() -
ReliableNow()) - skew_));
Is it possible to use this on all platforms and skip the ifdef? I'd prefer that
if it works, since it's one less thing that can get out of sync

[jeanluc1, 2011-09-15 19:51:09]

I like Brett's suggestion.  No other comments.

[Jói, 2011-09-15 22:56:31]

PTAL, I removed the special-casing.  Some of the trybots are hugely
backlogged (especially Mac) so it'll take a while to get confirmation, but I
think it's likely to work.

Cheers,
Jói


On Thu, Sep 15, 2011 at 7:51 PM, <jeanluc@chromium.org> wrote:

> I like Brett's suggestion.  No other comments.
>
>
>
http://codereview.chromium.**org/7910002/<http://codereview.chromium.org/7910...
>

[jeanluc1, 2011-09-15 23:01:16]

lgtm

[brettw, 2011-09-16 04:37:31]

LGTM