Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/chromeos/login/background_view.cc

Issue 7945014: Applied review comments from oshima for CL 7850026. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/background_view.cc
diff --git a/chrome/browser/chromeos/login/background_view.cc b/chrome/browser/chromeos/login/background_view.cc
index 71b1cdd06f07b53cbaf9de2ee7b8c5cc937d9447..6b3871e5dee480ad0ba93d49c754d8e888426db1 100644
--- a/chrome/browser/chromeos/login/background_view.cc
+++ b/chrome/browser/chromeos/login/background_view.cc
@@ -129,10 +129,6 @@ views::Widget* BackgroundView::CreateWindowContainingView(
const gfx::Rect& bounds,
const GURL& background_url,
BackgroundView** view) {
-#if defined(USE_AURA)
- // TODO(saintlou):
- return NULL;
-#else
oshima 2011/09/19 22:31:03 would it be possible to compile & link only webui
Emmanuel Saint-loubert-Bié 2011/09/19 23:26:02 That would be the goal. I am not sure we are ready
oshima 2011/09/20 04:59:17 webui oobe/login has been enabled for chromeos, so
Widget* window = new Widget;
Widget::InitParams params(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
params.bounds = bounds;
@@ -154,7 +150,6 @@ views::Widget* BackgroundView::CreateWindowContainingView(
LoginUtils::Get()->SetBackgroundView(*view);
return window;
-#endif
}
void BackgroundView::CreateModalPopup(views::WidgetDelegate* view) {

Powered by Google App Engine
This is Rietveld 408576698