Applied review comments from oshima for CL 7850026.

chrome/browser/chromeos/login/background_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/background_view.h"
 
 #include <string>
 #include <vector>
 
 #include "base/string16.h"
@@ skipping 111 matching lines @@
     shutdown_button_ = NULL;
     SchedulePaint();
   }
 }
 
 // static
 views::Widget* BackgroundView::CreateWindowContainingView(
     const gfx::Rect& bounds,
     const GURL& background_url,
     BackgroundView** view) {
-#if defined(USE_AURA)
-  // TODO(saintlou):
-  return NULL;
-#else

[oshima, 2011/09/19 22:31:03]

would it be possible to compile & link only webui version for aura?

[Emmanuel Saint-loubert-Bié, 2011/09/19 23:26:02]

That would be the goal. I am not sure we are ready yet.

[oshima, 2011/09/20 04:59:17]

webui oobe/login has been enabled for chromeos, so that should be possible.
screen locker can be simply removed for now.

   Widget* window = new Widget;
   Widget::InitParams params(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
   params.bounds = bounds;
   window->Init(params);
   *view = new BackgroundView();
   (*view)->Init(background_url);
 
   if ((*view)->ScreenSaverEnabled())
     (*view)->ShowScreenSaver();
 
   window->SetContentsView(*view);
 
   (*view)->UpdateWindowType();
 
   // This keeps the window from flashing at startup.
   GdkWindow* gdk_window = window->GetNativeView()->window;
   gdk_window_set_back_pixmap(gdk_window, NULL, false);
 
   LoginUtils::Get()->SetBackgroundView(*view);
 
   return window;
-#endif
 }
 
 void BackgroundView::CreateModalPopup(views::WidgetDelegate* view) {
   views::Widget* window = browser::CreateViewsWindow(
       GetNativeWindow(), view);
   window->SetAlwaysOnTop(true);
   window->Show();
 }
 
 gfx::NativeWindow BackgroundView::GetNativeWindow() const {
@@ skipping 218 matching lines @@
 
 void BackgroundView::UpdateWindowType() {
   std::vector<int> params;
   WmIpc::instance()->SetWindowType(
       GTK_WIDGET(GetNativeWindow()),
       WM_IPC_WINDOW_LOGIN_BACKGROUND,
       &params);
 }
 
 }  // namespace chromeos