Issue 7934003: MIPS: Fixed a bug in CallStubCompiler::CompileArrayPushCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7934003: MIPS: Fixed a bug in CallStubCompiler::CompileArrayPushCall. (Closed)

Created:
9 years, 3 months ago by Paul Lind

Modified:
9 years, 3 months ago

Reviewers:
Erik Corry, Yang, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixed a bug in CallStubCompiler::CompileArrayPushCall. An ARM PreIndex store was badly ported. BUG= TEST=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/mips/stub-cache-mips.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 3 months ago (2011-09-18 15:18:12 UTC) #3

Landed as 9317.

Since there is no BUG= or TEST= I suppose that this was not covered by the
existing tests.  If at all possible fixes like this should be accompanied with a
regression test.

Expand Messages | Collapse Messages