Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 7934003: MIPS: Fixed a bug in CallStubCompiler::CompileArrayPushCall. (Closed)
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1607 __ sw(v0, FieldMemOperand(receiver, JSArray::kLengthOffset)); 1607 __ sw(v0, FieldMemOperand(receiver, JSArray::kLengthOffset));
1608 1608
1609 // Push the element. 1609 // Push the element.
1610 __ lw(t0, MemOperand(sp, (argc - 1) * kPointerSize)); 1610 __ lw(t0, MemOperand(sp, (argc - 1) * kPointerSize));
1611 // We may need a register containing the address end_elements below, 1611 // We may need a register containing the address end_elements below,
1612 // so write back the value in end_elements. 1612 // so write back the value in end_elements.
1613 __ sll(end_elements, v0, kPointerSizeLog2 - kSmiTagSize); 1613 __ sll(end_elements, v0, kPointerSizeLog2 - kSmiTagSize);
1614 __ Addu(end_elements, elements, end_elements); 1614 __ Addu(end_elements, elements, end_elements);
1615 const int kEndElementsOffset = 1615 const int kEndElementsOffset =
1616 FixedArray::kHeaderSize - kHeapObjectTag - argc * kPointerSize; 1616 FixedArray::kHeaderSize - kHeapObjectTag - argc * kPointerSize;
1617 __ sw(t0, MemOperand(end_elements, kEndElementsOffset)); 1617 __ Addu(end_elements, end_elements, kEndElementsOffset);
1618 __ Addu(end_elements, end_elements, kPointerSize); 1618 __ sw(t0, MemOperand(end_elements));
1619 1619
1620 // Check for a smi. 1620 // Check for a smi.
1621 __ JumpIfNotSmi(t0, &with_write_barrier); 1621 __ JumpIfNotSmi(t0, &with_write_barrier);
1622 __ bind(&exit); 1622 __ bind(&exit);
1623 __ Drop(argc + 1); 1623 __ Drop(argc + 1);
1624 __ Ret(); 1624 __ Ret();
1625 1625
1626 __ bind(&with_write_barrier); 1626 __ bind(&with_write_barrier);
1627 __ InNewSpace(elements, t0, eq, &exit); 1627 __ InNewSpace(elements, t0, eq, &exit);
1628 __ RecordWriteHelper(elements, end_elements, t0); 1628 __ RecordWriteHelper(elements, end_elements, t0);
(...skipping 2872 matching lines...) Expand 10 before | Expand all | Expand 10 after
4501 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric(); 4501 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric();
4502 __ Jump(ic, RelocInfo::CODE_TARGET); 4502 __ Jump(ic, RelocInfo::CODE_TARGET);
4503 } 4503 }
4504 4504
4505 4505
4506 #undef __ 4506 #undef __
4507 4507
4508 } } // namespace v8::internal 4508 } } // namespace v8::internal
4509 4509
4510 #endif // V8_TARGET_ARCH_MIPS 4510 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698