Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 7932010: MIPS: Fix assertion-fail on cacheflush from generated code. (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 2 months ago
Reviewers:
Erik Corry, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix assertion-fail on cacheflush from generated code. Fix a mips-specific CallCFunction assertion, when checking for valid frames on the stack. We fake it with AllowExternalCallThatCantCauseGC(). BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
a small bug showed up under our crankshaft code.
9 years, 3 months ago (2011-09-17 02:21:49 UTC) #1
Erik Corry
lgtm
9 years, 3 months ago (2011-09-18 14:56:48 UTC) #2
Erik Corry
9 years, 3 months ago (2011-09-18 15:06:18 UTC) #3
Landed in 9315

Powered by Google App Engine
This is Rietveld 408576698