Refactoring recently closed tab filtering

chrome/browser/sessions/session_utils.h

Index: chrome/browser/sessions/session_utils.h
diff --git a/chrome/browser/sessions/session_utils.h b/chrome/browser/sessions/session_utils.h
new file mode 100644
index 0000000000000000000000000000000000000000..314a2789a4cf4f3d8d73c09cbdff73917473dcd3
--- /dev/null
+++ b/chrome/browser/sessions/session_utils.h
@@ -0,0 +1,22 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_
+#define CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_
+#pragma once
+
+#include "chrome/browser/sessions/tab_restore_service.h"
+
+class SessionUtils {
+ public:
+  // Fill the passed list with the entries() from the TabRestoreService
+  // filtering out the ones with the same title and URL as a previous entry.
+  // This avoid filling the list with things that look like duplicates. A user
+  // can still access the filtered out version by restoring the one he sees as
+  // it will allow the older one to show.
+  static void FilteredEntries(TabRestoreService* service,

[sky, 2011/09/20 16:24:46]

Don't make this depend upon TabRestoreService. Instead either make filtered_tabs
be initialized to services->entries() or make this take two Entries, one const&
and the other a pointer.

[noyau (Ping after 24h), 2011/09/20 17:09:35]

Done.

+                              TabRestoreService::Entries* filteredTabs);

[sky, 2011/09/20 16:24:46]

filtered_tabs. But filtered_entries is a better name since the type is entries.

[noyau (Ping after 24h), 2011/09/20 17:09:35]

Done.

+};

[sky, 2011/09/20 16:24:46]

add a private field and DISALLOW_IMPLICIT_CONSTRUCTORS.

[noyau (Ping after 24h), 2011/09/20 17:09:35]

Done.

+
+#endif  // CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_