chrome/browser/sessions/session_utils.h - Issue 7931027: Refactoring recently closed tab filtering

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_utils.h

Issue 7931027: Refactoring recently closed tab filtering (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Implementing reviewer feedback Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | chrome/browser/sessions/session_utils.cc » ('j') | chrome/browser/sessions/session_utils.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_

	6 #define CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_

	7 #pragma once

	8

	9 #include "chrome/browser/sessions/tab_restore_service.h"

	10

	11 class SessionUtils {

	12 public:

	13 // Fill the passed list with the entries() from the TabRestoreService

	14 // filtering out the ones with the same title and URL as a previous entry.

	15 // This avoid filling the list with things that look like duplicates. A user

	16 // can still access the filtered out version by restoring the one he sees as

	17 // it will allow the older one to show.

	18 static void FilteredEntries(TabRestoreService* service,
	sky 2011/09/20 16:24:46 Don't make this depend upon TabRestoreService. Ins Don't make this depend upon TabRestoreService. Instead either make filtered_tabs be initialized to services->entries() or make this take two Entries, one const& and the other a pointer. noyau (Ping after 24h) 2011/09/20 17:09:35 Done. Show quoted text On 2011/09/20 16:24:46, sky wrote: > Don't make this depend upon TabRestoreService. Instead either make filtered_tabs > be initialized to services->entries() or make this take two Entries, one const& > and the other a pointer. Done.
	19 TabRestoreService::Entries* filteredTabs);
	sky 2011/09/20 16:24:46 filtered_tabs. But filtered_entries is a better na filtered_tabs. But filtered_entries is a better name since the type is entries. noyau (Ping after 24h) 2011/09/20 17:09:35 Done. Show quoted text On 2011/09/20 16:24:46, sky wrote: > filtered_tabs. But filtered_entries is a better name since the type is entries. Done.
	20 };
	sky 2011/09/20 16:24:46 add a private field and DISALLOW_IMPLICIT_CONSTRUC add a private field and DISALLOW_IMPLICIT_CONSTRUCTORS. noyau (Ping after 24h) 2011/09/20 17:09:35 Done. Show quoted text On 2011/09/20 16:24:46, sky wrote: > add a private field and DISALLOW_IMPLICIT_CONSTRUCTORS. Done.
	21

	22 #endif // CHROME_BROWSER_SESSIONS_SESSION_UTILS_H_

OLD	NEW