[Sync] Move change-related methods out of SyncManager::Observer

chrome/browser/sync/internal_api/change_record.h

Index: chrome/browser/sync/internal_api/change_record.h
diff --git a/chrome/browser/sync/internal_api/change_record.h b/chrome/browser/sync/internal_api/change_record.h
index 1c19d73d21f4192e8aba29a79c7010416d44d73e..6276b9902da92145bb891cb2180acf82993655d1 100644
--- a/chrome/browser/sync/internal_api/change_record.h
+++ b/chrome/browser/sync/internal_api/change_record.h
@@ -9,11 +9,12 @@
 #include "base/memory/linked_ptr.h"
 #include "chrome/browser/sync/protocol/password_specifics.pb.h"
 #include "chrome/browser/sync/protocol/sync.pb.h"
+#include "chrome/browser/sync/syncable/syncable.h"

[tim (not reviewing), 2011/09/20 16:04:59]

Hm. I suppose this isn't enforced by the deps rules (yet) because we're in
internal_api. But we shouldn't include internal types from headers that we can
include from glue.  Something like EntryKernel should never escape into that
world.

[akalin, 2011/09/20 21:14:42]

Turns out I don't really need it for ToValue(), although I may in the future (in
which case I'll just forward-declare).  Done.

 #include "chrome/browser/sync/util/immutable.h"
 
 namespace base {
 class DictionaryValue;
-}  // namespace
+}  // namespace base
 
 namespace sync_api {
 
@@ -50,7 +51,8 @@ struct ChangeRecord {
   ~ChangeRecord();
 
   // Transfers ownership of the DictionaryValue to the caller.
-  base::DictionaryValue* ToValue(const BaseTransaction* trans) const;
+  base::DictionaryValue* ToValue(
+      const syncable::ImmutableEntryKernelMutationMap& mutations) const;
 
   int64 id;
   Action action;