[Sync] Move change-related methods out of SyncManager::Observer

chrome/browser/sync/internal_api/change_record.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_INTERNAL_API_CHANGE_RECORD_H_
 #define CHROME_BROWSER_SYNC_INTERNAL_API_CHANGE_RECORD_H_
 
 #include "base/basictypes.h"
 #include "base/memory/linked_ptr.h"
 #include "chrome/browser/sync/protocol/password_specifics.pb.h"
 #include "chrome/browser/sync/protocol/sync.pb.h"
+#include "chrome/browser/sync/syncable/syncable.h"

[tim (not reviewing), 2011/09/20 16:04:59]

Hm. I suppose this isn't enforced by the deps rules (yet) because we're in
internal_api. But we shouldn't include internal types from headers that we can
include from glue.  Something like EntryKernel should never escape into that
world.

[akalin, 2011/09/20 21:14:42]

Turns out I don't really need it for ToValue(), although I may in the future (in
which case I'll just forward-declare).  Done.

 #include "chrome/browser/sync/util/immutable.h"
 
 namespace base {
 class DictionaryValue;
-}  // namespace
+}  // namespace base
 
 namespace sync_api {
 
 class BaseTransaction;
 
 // TODO(zea): One day get passwords playing nicely with the rest of encryption
 // and get rid of this.
 class ExtraPasswordChangeRecordData {
  public:
   ExtraPasswordChangeRecordData();
@@ skipping 16 matching lines @@
 struct ChangeRecord {
   enum Action {
     ACTION_ADD,
     ACTION_DELETE,
     ACTION_UPDATE,
   };
   ChangeRecord();
   ~ChangeRecord();
 
   // Transfers ownership of the DictionaryValue to the caller.
-  base::DictionaryValue* ToValue(const BaseTransaction* trans) const;
+  base::DictionaryValue* ToValue(
+      const syncable::ImmutableEntryKernelMutationMap& mutations) const;
 
   int64 id;
   Action action;
   sync_pb::EntitySpecifics specifics;
   linked_ptr<ExtraPasswordChangeRecordData> extra;
 };
 
 typedef std::vector<ChangeRecord> ChangeRecordList;
 
 typedef browser_sync::Immutable<ChangeRecordList> ImmutableChangeRecordList;
 
 } // namespace sync_api
 
 #endif  // CHROME_BROWSER_SYNC_INTERNAL_API_CHANGE_RECORD_H_