Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3814)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 7920023: Fix crashes related to the extension uninstall dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make Show() pure virtual Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
index 23119f265acc8032821383f3f5a49bfcf6d3230e..3d8b1a0361fbbbadbbc604ab9320cab52f5b9780 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm
@@ -40,18 +40,19 @@ class AsyncUninstaller : public ExtensionUninstallDialog::Delegate {
AsyncUninstaller(const Extension* extension, Profile* profile)
: extension_(extension),
profile_(profile) {
- extension_uninstall_dialog_.reset(new ExtensionUninstallDialog(profile));
- extension_uninstall_dialog_->ConfirmUninstall(this, extension_);
+ extension_uninstall_dialog_.reset(
+ ExtensionUninstallDialog::Create(profile, this));
+ extension_uninstall_dialog_->ConfirmUninstall(extension_);
}
~AsyncUninstaller() {}
// ExtensionUninstallDialog::Delegate:
- virtual void ExtensionDialogAccepted() {
+ virtual void ExtensionUninstallAccepted() {
profile_->GetExtensionService()->
UninstallExtension(extension_->id(), false, NULL);
}
- virtual void ExtensionDialogCanceled() {}
+ virtual void ExtensionUninstallCanceled() {}
private:
// The extension that we're loading the icon for. Weak.
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698